Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformatted Codebase #95

Closed
wants to merge 2 commits into from

Conversation

Hiteshgautam01
Copy link
Contributor

@Hiteshgautam01 Hiteshgautam01 commented Aug 11, 2018

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the checks with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@sagar15795
Copy link
Member

@Hiteshgautam01 Could you please explain what have you done in it?

@Hiteshgautam01
Copy link
Contributor Author

Hiteshgautam01 commented Aug 12, 2018

Hey @sagar15795, What this PR does:-

  1. keep getters and setters together
  2. Allows us to group overridden methods by class and interface.
  3. Keeps dependent methods together. For instance, service() method calls util() method, and you want to keep util() after service().
  4. Defines elements order as a list of rules where every rules has a set of matchers like modifier or type.
  5. Order elements alphabetically.
  6. Proper indentation
  7. Perfect Arrangement for XML.
  8. Optimize imports
    *In this PR, the whole code is rearranged. Nothing is deleted or added.

@sagar15795
Copy link
Member

sagar15795 commented Aug 12, 2018

@Hiteshgautam01 I think your configurations are not correct. So it will be good if you close this PR. Let me do this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants