Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expect script for OP-TEE CI #45

Merged
merged 2 commits into from Sep 27, 2021
Merged

Add expect script for OP-TEE CI #45

merged 2 commits into from Sep 27, 2021

Conversation

DemesneGH
Copy link
Contributor

@DemesneGH DemesneGH commented Sep 23, 2021

Add ci/qemu-check.exp which invoked in OP-TEE/build/qemu_v8.mk
First, build Rust applications in buildroot:

$ (cd build && make toolchains && make OPTEE_RUST_ENABLE=y CFG_TEE_RAM_VA_SIZE=0x00300000)

Then trigger the CI for Rust applications in OP-TEE by:

$ (cd build && make CFG_TEE_CORE_LOG_LEVEL=0 check-rust)

@DemesneGH
Copy link
Contributor Author

Related commit in OPTEE/build:
DemesneGH/build@31dc606

@mssun
Copy link
Member

mssun commented Sep 23, 2021

@DemesneGH
Copy link
Contributor Author

Can you also add this in our CI? https://github.com/apache/incubator-teaclave-trustzone-sdk/blob/master/.github/workflows/ci.yml

@mssun I have written the ci script in this branch https://github.com/DemesneGH/rust-optee-trustzone-sdk/blob/test-ci/.github/workflows/ci.yml and it worked. But in that script, I had to checkout my commits which have not been merged yet (https://github.com/DemesneGH/rust-optee-trustzone-sdk/blob/test-ci/.github/workflows/ci.yml#L38-L43).
Shall we add this to our CI now? Or add this after merging this PR and the PR in OP-TEE/build?

@mssun
Copy link
Member

mssun commented Sep 24, 2021

You can commit the changes of ci.yml here. GitHub Actions will automatically run based on the latest ci.yml file.

@DemesneGH
Copy link
Contributor Author

Since the new CI job clones OP-TEE upstream repositories (optee_rust has been pinned to a fixed version in OP-TEE/manifest), I think we should follow these steps before merging the CI job:

  1. Merge ci/qemu-check.exp into Teaclave Trustzone SDK.
  2. Merge DemesneGH/build@31dc606 into OP-TEE/build.
  3. Pin optee_rust to the latest version in OPTEE/manifest.

Then we can merge the CI job into Azure Pipelines or Github Actions.
Is this the proper way?

@mssun mssun merged commit 8520a20 into apache:master Sep 27, 2021
@mssun
Copy link
Member

mssun commented Sep 27, 2021

@DemesneGH, thanks!

Ok, sure. Let's do it.

RMheng pushed a commit to RMheng/incubator-teaclave-trustzone-sdk that referenced this pull request Oct 15, 2021
* Add expect script for OP-TEE CI
* Add job for OP-TEE CI
RMheng pushed a commit to RMheng/incubator-teaclave-trustzone-sdk that referenced this pull request Oct 16, 2021
* Add expect script for OP-TEE CI
* Add job for OP-TEE CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants