-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrite kms with prost #112
Conversation
@@ -12,6 +12,9 @@ mesalock_sgx = ["sgx_tstd", "mesatee_core/mesalock_sgx"] | |||
cov = ["sgx_cov"] | |||
|
|||
[dependencies] | |||
prost = { version = "0.5.0" } | |||
bytes = { version = ">= 0.4.12"} # unix app depends on 0.4.12, while sgx lib depends on 0.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note: the revelent PR on prost is https://github.com/danburkert/prost/pull/246 . Once it's merged, I'll upgrade the forked prost.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use raw string literal but not escape characters?
Refer to: https://rahul-thakoor.github.io/rust-raw-string-literals/
Do you mean escape characters in Escape characters are still needed when we use raw strings, because the escape characters are caused by |
Ok, I understand. Thanks for the explanation. |
In |
} | ||
buf.push_str(" }"); | ||
buf.push_str(LINE_ENDING); | ||
buf.push_str(" }\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buf.push_str(" }\n");
=> buf.push_str(" }");
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with the PR. Thanks!
Merged. Thank you! |
[services/kms] Use protobuf to define and generate KMS protocol (apache#112)
Description
Rewrite kms with prost:
Proto file: mesatee_services/kms/proto/src/kms.proto
Generated file: mesatee_services/kms/proto/src/prost_generated/kms_proto.rs
API Document will be updated later.
Type of change (select applied and DELETE the others)
How Has This Been Tested?
CI. http://ci.mesalock-linux.org/litongxin1991/incubator-mesatee/21
Checklist (check ALL before submitting PR, even not applicable)
master
.