Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] Remove unneccessary dependency #170

Merged
merged 2 commits into from Dec 16, 2019
Merged

[cli] Remove unneccessary dependency #170

merged 2 commits into from Dec 16, 2019

Conversation

mssun
Copy link
Member

@mssun mssun commented Dec 16, 2019 •
edited

Description

quicli is not useful in teaclave_cli right now.

Fixes #169

Type of change (select applied and DELETE the others)

  • Code cleanup or just sync with upstream third-party crates

How Has This Been Tested?

CI: https://ci.mesalock-linux.org/mssun/incubator-mesatee/158

Checklist (check ALL before submitting PR, even not applicable)

  • Fork the repo and create your branch from master.
  • If you've added code that should be tested, add tests.
  • If you've changed APIs, update the documentation.
  • Ensure the tests pass (see CI results).
  • Make sure your code lints/format.

m4sterchain
m4sterchain reviewed Dec 16, 2019
View reviewed changes
teaclave_cli/Cargo.toml
@@ -8,7 +8,6 @@ edition = "2018"

[dependencies]
mesatee_core = "0.1.0"
quicli = "0.4.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove quicli in cargo vendor？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's okay to have more dependencies in third_party/crates-io. At least, it does not affect the compilation time. We can cleanup them later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. We can cleanup the third_party crates vendor before the release.

@mssun mssun merged commit e3fc463 into apache:master Dec 16, 2019
@mssun mssun deleted the strip-dependency branch December 16, 2019 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4sterchain m4sterchain m4sterchain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dependency quicli in teaclave_cli
2 participants
@mssun @m4sterchain