Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Remove unneccessary dependency #170

Merged
merged 2 commits into from Dec 16, 2019
Merged

Conversation

@mssun
Copy link
Member

mssun commented Dec 16, 2019

Description

quicli is not useful in teaclave_cli right now.

Fixes #169

Type of change (select applied and DELETE the others)

  • Code cleanup or just sync with upstream third-party crates

How Has This Been Tested?

CI: https://ci.mesalock-linux.org/mssun/incubator-mesatee/158

Checklist (check ALL before submitting PR, even not applicable)

  • Fork the repo and create your branch from master.
  • If you've added code that should be tested, add tests.
  • If you've changed APIs, update the documentation.
  • Ensure the tests pass (see CI results).
  • Make sure your code lints/format.
mssun added 2 commits Dec 16, 2019
@@ -8,7 +8,6 @@ edition = "2018"

[dependencies]
mesatee_core = "0.1.0"
quicli = "0.4.0"

This comment has been minimized.

Copy link
@m4sterchain

m4sterchain Dec 16, 2019

Contributor

Should we remove quicli in cargo vendor?

This comment has been minimized.

Copy link
@mssun

mssun Dec 16, 2019

Author Member

That's okay to have more dependencies in third_party/crates-io. At least, it does not affect the compilation time. We can cleanup them later.

This comment has been minimized.

Copy link
@m4sterchain

m4sterchain Dec 16, 2019

Contributor

Agree. We can cleanup the third_party crates vendor before the release.

@mssun mssun merged commit e3fc463 into apache:master Dec 16, 2019
@mssun mssun deleted the mssun:strip-dependency branch Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.