Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apache compliance #689

Merged
merged 5 commits into from
May 9, 2023
Merged

Apache compliance #689

merged 5 commits into from
May 9, 2023

Conversation

henrysun007
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Adjust according to IPMC advice (https://lists.apache.org/thread/6xbzdbrcd35drh7315mcsp8ko49mlx23).

Fixes #683

Type of change (select or add applied and delete the others)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • API change with a documentation update
  • Additional test coverage
  • Code cleanup or just sync with upstream third-party crates

How has this been tested?

Checklist

  • Fork the repo and create your branch from master.
  • If you've added code that should be tested, add tests.
  • If you've changed APIs, update the documentation.
  • Ensure the tests pass (see CI results).
  • Make sure your code lints/format.

@henrysun007 henrysun007 requested a review from mssun April 25, 2023 08:23
qinkunbao
qinkunbao reviewed May 5, 2023
View reviewed changes
third_party/wamr.patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason of including this patch in this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch is for running wamr in teaclave originally. I modified it to remove unnecessary .wasm files from the source code for release.

@henrysun007 henrysun007 merged commit 49c259e into apache:master May 9, 2023
13 checks passed
@henrysun007 henrysun007 deleted the apache-compliance branch May 9, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinkunbao qinkunbao qinkunbao left review comments

@volcano0dr volcano0dr volcano0dr approved these changes

@mssun mssun Awaiting requested review from mssun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copyright year needs update
3 participants
@henrysun007 @qinkunbao @volcano0dr