Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

Error with invalid discovery messages #277

Closed
atoulme opened this issue Jun 13, 2021 · 1 comment · Fixed by #451
Closed

Error with invalid discovery messages #277

atoulme opened this issue Jun 13, 2021 · 1 comment · Fixed by #451
Labels
enhancement New feature or request

Comments

@atoulme
Copy link
Member

atoulme commented Jun 13, 2021

This error is reported during discovery:

Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: 06:55:26.613 [DefaultDispatcher-worker-1] ERROR org.apache.tuweni.devp2p.DiscoveryService - ÐΞVp2p discovery 957395249: unexpected error during packet handling
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: com.google.common.util.concurrent.UncheckedExecutionException: java.lang.IllegalArgumentException: Invalid point coordinates
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2050)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at com.google.common.cache.LocalCache.get(LocalCache.java:3952)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at com.google.common.cache.LocalCache$LocalManualCache.get(LocalCache.java:4871)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at org.apache.tuweni.devp2p.DevP2PPeerRoutingTable.hashForId(PeerRoutingTable.kt:100)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at org.apache.tuweni.devp2p.DevP2PPeerRoutingTable.nearest(PeerRoutingTable.kt:92)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at org.apache.tuweni.devp2p.CoroutineDiscoveryService.neighbors(DiscoveryService.kt:863)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at org.apache.tuweni.devp2p.CoroutineDiscoveryService.handleFindNode(DiscoveryService.kt:610)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at org.apache.tuweni.devp2p.CoroutineDiscoveryService$handleFindNode$1.invokeSuspend(DiscoveryService.kt)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at kotlinx.coroutines.internal.ScopeCoroutine.afterResume(Scopes.kt:32)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at kotlinx.coroutines.AbstractCoroutine.resumeWith(AbstractCoroutine.kt:113)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:46)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:571)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:750)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:678)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:665)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: Caused by: java.lang.IllegalArgumentException: Invalid point coordinates
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at org.bouncycastle.math.ec.ECCurve.validatePoint(ECCurve.java:125)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at org.bouncycastle.math.ec.ECCurve.decodePoint(ECCurve.java:418)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at org.apache.tuweni.crypto.SECP256K1$PublicKey.asEcPoint(SECP256K1.java:707)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at org.apache.tuweni.devp2p.EthereumNodeRecord$Companion.nodeId(EthereumNodeRecord.kt:58)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at org.apache.tuweni.devp2p.DevP2PPeerRoutingTable$hashForId$1.call(PeerRoutingTable.kt:100)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at org.apache.tuweni.devp2p.DevP2PPeerRoutingTable$hashForId$1.call(PeerRoutingTable.kt:69)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at com.google.common.cache.LocalCache$LocalManualCache$1.load(LocalCache.java:4876)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3528)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2277)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2154)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2044)
Jun 13 06:55:26 ip-172-31-23-167 crawler[3231927]: #011... 16 common frames omitted
@atoulme atoulme added the enhancement New feature or request label Jun 14, 2021
@atoulme
Copy link
Member Author

atoulme commented Jun 14, 2021

Not a bug, but we should catch this and log a warning.

atoulme added a commit to atoulme/tuweni that referenced this issue Dec 11, 2022
atoulme added a commit to atoulme/tuweni that referenced this issue Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant