Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONCATENATION to tflite frontend, support Inception V3 #2643

Merged
merged 6 commits into from
Feb 26, 2019
Merged

Add CONCATENATION to tflite frontend, support Inception V3 #2643

merged 6 commits into from
Feb 26, 2019

Conversation

ariwaranosai
Copy link
Contributor

add concatenation to tflite frontend to support inception v3.

@tqchen
Copy link
Member

tqchen commented Feb 21, 2019

@kazum @FrozenGene @Huyuwei please help review this PR

python/tvm/relay/frontend/tflite.py Show resolved Hide resolved
python/tvm/relay/frontend/tflite.py Outdated Show resolved Hide resolved
python/tvm/relay/frontend/tflite.py Outdated Show resolved Hide resolved
tests/python/frontend/tflite/test_forward.py Outdated Show resolved Hide resolved
tests/python/frontend/tflite/test_forward.py Outdated Show resolved Hide resolved
tests/python/frontend/tflite/test_forward.py Outdated Show resolved Hide resolved
tests/python/frontend/tflite/test_forward.py Show resolved Hide resolved
@ariwaranosai
Copy link
Contributor Author

@FrozenGene @srkreddy1238 fixed, please check again.

Copy link
Contributor

@kazum kazum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@tqchen
Copy link
Member

tqchen commented Feb 25, 2019

@srkreddy1238 please follow up on this PR

Copy link
Contributor

@srkreddy1238 srkreddy1238 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ariwaranosai LGTM.

@srkreddy1238 srkreddy1238 merged commit 6ad7ce8 into apache:master Feb 26, 2019
@tqchen
Copy link
Member

tqchen commented Feb 26, 2019

Thanks @kazum @FrozenGene for reviewing

@ariwaranosai ariwaranosai deleted the relay_tflite branch February 27, 2019 07:02
@yzhliu yzhliu mentioned this pull request Mar 2, 2019
28 tasks
wweic pushed a commit to neo-ai/tvm that referenced this pull request Mar 9, 2019
* Add CONCATENATION to tflite frontend

* fix typo

* Fix codestyle

* Fix code style

* simplify convert map

* Update
wweic pushed a commit to neo-ai/tvm that referenced this pull request Mar 12, 2019
* Add CONCATENATION to tflite frontend

* fix typo

* Fix codestyle

* Fix code style

* simplify convert map

* Update
wweic pushed a commit to neo-ai/tvm that referenced this pull request Mar 12, 2019
* Add CONCATENATION to tflite frontend

* fix typo

* Fix codestyle

* Fix code style

* simplify convert map

* Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants