[Torch] Fix aten::max and aten::min conversion #6372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 17, 2020
* fix aten::max and aten::min conversion * remove print
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 18, 2020
* fix aten::max and aten::min conversion * remove print
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 18, 2020
* fix aten::max and aten::min conversion * remove print
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the issue found by hummingbird project
microsoft/hummingbird#232 (comment)
torch.max and min have 3 cases to handle, but we have conversion only for one of the cases.
https://pytorch.org/docs/stable/generated/torch.max.html
Also added a conversion for
leaky_relu_(seen problems from this op a few times)please review @siju-samuel