Skip to content

Commit

Permalink
[MINOR] test: fix CoordinatorGrpcTest#shuffleServerHeartbeatTest on L…
Browse files Browse the repository at this point in the history
…inux SSD platform (#738)

### What changes were proposed in this pull request?

Fix CoordinatorGrpcTest#shuffleServerHeartbeatTest on Linux SSD platform

### Why are the changes needed?

```
[INFO] Results:                                                                                                                     
[INFO]                                                                                                                              
[ERROR] Failures:                                                                                                                   
[ERROR]   CoordinatorGrpcTest.shuffleServerHeartbeatTest:240 expected: <HDD> but was: <SSD>                                         
[ERROR] Errors:                                                                                                                     
[ERROR]   CoordinatorGrpcTest.getShuffleAssignmentsTest:125 » Runtime No shuffle server ...                                         
[ERROR]   CoordinatorGrpcTest.rpcMetricsTest:274 » Runtime No shuffle server connected                                              
[INFO]                                                                                                                              
[ERROR] Tests run: 6, Failures: 1, Errors: 2, Skipped: 0                                                                            
```

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

```
[INFO] Running org.apache.uniffle.test.CoordinatorGrpcTest                                                                          
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.622 s - in org.apache.uniffle.test.CoordinatorGrpcTest    
[INFO]                                                                                                                              
[INFO] Results:                                                                                                                     
[INFO]                                                                                                                              
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0                                                                             
[INFO] 
```
  • Loading branch information
kaijchen committed Mar 18, 2023
1 parent d82e10d commit 1021031
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,9 @@ public void shuffleServerHeartbeatTest() throws Exception {
ServerNode node = nodes.get(0);
assertEquals(1, node.getStorageInfo().size());
StorageInfo infoHead = node.getStorageInfo().values().iterator().next();
assertEquals(StorageMedia.HDD, infoHead.getType());
final StorageInfo expectedStorageInfo = shuffleServers.get(1)
.getStorageManager().getStorageInfo().values().iterator().next();
assertEquals(expectedStorageInfo, infoHead);
assertEquals(StorageStatus.NORMAL, infoHead.getStatus());
assertTrue(node.getTags().contains(Constants.SHUFFLE_SERVER_VERSION));
assertTrue(scm.getTagToNodes().get(Constants.SHUFFLE_SERVER_VERSION).contains(node));
Expand Down

0 comments on commit 1021031

Please sign in to comment.