Remove unread protected field in Checker

apache · Jan 30, 2023 · 85d451d · 85d451d
1 parent 6973e2b
commit 85d451d
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/server/src/main/java/org/apache/uniffle/server/Checker.java b/server/src/main/java/org/apache/uniffle/server/Checker.java
@@ -19,10 +19,7 @@
 
 public abstract class Checker {
 
-  protected ShuffleServerConf conf;
-
   Checker(ShuffleServerConf conf) {
-    this.conf = conf;
   }
 
   abstract boolean checkIsHealthy();

diff --git a/spotbugs-exclude.xml b/spotbugs-exclude.xml
@@ -20,6 +20,6 @@
     <Package name="~org\.apache\.uniffle\.proto.*"/>
   </Match>
   <Match>
-    <Bug pattern="MS_EXPOSE_REP,EI_EXPOSE_REP,EI_EXPOSE_REP2,EI_EXPOSE_STATIC_REP2,THROWS_METHOD_THROWS_RUNTIMEEXCEPTION,THROWS_METHOD_THROWS_CLAUSE_BASIC_EXCEPTION,REC_CATCH_EXCEPTION,THROWS_METHOD_THROWS_CLAUSE_THROWABLE,MS_PKGPROTECT,MS_CANNOT_BE_FINAL,UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD,SE_BAD_FIELD,URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD,SC_START_IN_CTOR,SWL_SLEEP_WITH_LOCK_HELD,IS2_INCONSISTENT_SYNC" />
+    <Bug pattern="MS_EXPOSE_REP,EI_EXPOSE_REP,EI_EXPOSE_REP2,EI_EXPOSE_STATIC_REP2,THROWS_METHOD_THROWS_RUNTIMEEXCEPTION,THROWS_METHOD_THROWS_CLAUSE_BASIC_EXCEPTION,REC_CATCH_EXCEPTION,THROWS_METHOD_THROWS_CLAUSE_THROWABLE,MS_PKGPROTECT,MS_CANNOT_BE_FINAL,UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD,SE_BAD_FIELD,SC_START_IN_CTOR,SWL_SLEEP_WITH_LOCK_HELD,IS2_INCONSISTENT_SYNC" />
   </Match>
 </FindBugsFilter>