Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Add slack link to the readme.md #1095

Closed
2 of 3 tasks
jerqi opened this issue Aug 5, 2023 · 2 comments · Fixed by #1099
Closed
2 of 3 tasks

[DOCS] Add slack link to the readme.md #1095

jerqi opened this issue Aug 5, 2023 · 2 comments · Fixed by #1099
Assignees
@ASDasd341
Labels
good first issue Good for newcomers

Comments

@jerqi
Copy link
Contributor

jerqi commented Aug 5, 2023

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Which parts of the documentation do you think need improvement?

Our slack link is https://join.slack.com/t/the-asf/shared_invite/zt-1fm9561yr-uzTpjqg3jf5nxSJV5AE3KQ
We can refer to https://github.com/apache/iceberg/blob/4f401a7779a56c25e9371cc3a95a13a51012cd6c/README.md?plain=1#L24

Affects Version(s)

master

Improving the documentation

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@jerqi jerqi added the good first issue Good for newcomers label Aug 5, 2023
@jerqi jerqi mentioned this issue Aug 5, 2023
Open
17 tasks
@ASDasd341
Copy link

i can do that.

@jerqi
Copy link
Contributor Author

jerqi commented Aug 5, 2023

Thanks.

ducksblock added a commit to ducksblock/incubator-uniffle that referenced this issue Aug 5, 2023
@ducksblock
Fix apache#1095: Add slack link to the readme.md
394a7b5
@ducksblock ducksblock mentioned this issue Aug 5, 2023
Merged
jerqi pushed a commit that referenced this issue Aug 6, 2023
@ducksblock
[#1095] doc: Add slack link to the readme.md (#1099)
7b42ea4 
### What changes were proposed in this pull request?

I have added the Slack link to the README.md to make it easier for anyone to get access to the Slack workspace.

### Why are the changes needed?

Without the Slack link it was confusing if anyone wanted to contact the team.

Fix: #1095

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ASDasd341 ASDasd341

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1095] doc: Add slack link to the readme.md ducksblock/incubator-uniffle
2 participants
@jerqi @ASDasd341