Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Unregister shuffle explicitly when application is stopped. #1115

Closed
3 tasks done
zhengchenyu opened this issue Aug 8, 2023 · 0 comments · Fixed by #1131
Closed
3 tasks done

[Improvement] Unregister shuffle explicitly when application is stopped. #1115

zhengchenyu opened this issue Aug 8, 2023 · 0 comments · Fixed by #1131

Comments

@zhengchenyu
Copy link
Collaborator

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

For MR/Tez, as applications is stopped, we should unregister shuffle explicitly. There are no need to wait timeout.

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
zhengchenyu added a commit to zhengchenyu/incubator-uniffle that referenced this issue Aug 11, 2023
@zhengchenyu
[apache#1115] improvement: Unregister shuffle explicitly when applica…
7fb0f91 
…tion is stopped.
@zhengchenyu zhengchenyu mentioned this issue Aug 11, 2023
Merged
zuston pushed a commit that referenced this issue Aug 11, 2023
@zhengchenyu
[#1115] improvement(tez&mr): Unregister shuffle explicitly when appli…
110531d 
…cation is stopped. (#1131)

### What changes were proposed in this pull request?

For MR/Tez, as applications is stopped, we should unregister shuffle explicitly. There are no need to wait timeout.

### Why are the changes needed?

Fix: #1115 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

test in yarn cluster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@zhengchenyu