Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposing the getDataLen method for ShuffleDataResult #1164

Closed
jerqi opened this issue Aug 22, 2023 · 1 comment · Fixed by #1170
Closed

Exposing the getDataLen method for ShuffleDataResult #1164

jerqi opened this issue Aug 22, 2023 · 1 comment · Fixed by #1170
Assignees
@pegasas
Labels
good first issue Good for newcomers

Comments

@jerqi
Copy link
Contributor

jerqi commented Aug 22, 2023 

          Why not exposing the `bufferDataLen` method for being invoked?

Originally posted by @zuston in #1162 (comment)
@jerqi jerqi changed the title Why not exposing the bufferDataLen method for being invoked? Exposing the getDataLen method for ShuffleDataResult Aug 22, 2023
@jerqi jerqi mentioned this issue Aug 22, 2023
Merged
@jerqi jerqi added the good first issue Good for newcomers label Aug 23, 2023
@pegasas
Copy link
Contributor

pegasas commented Aug 23, 2023

Hi, @jerqi ,

I will make a PR for this to go through shuffle server logic for learning.
Would you please assign me this issue?

@pegasas pegasas mentioned this issue Aug 24, 2023
Merged
jerqi pushed a commit that referenced this issue Aug 28, 2023
@pegasas
[#1164] refactor: Exposing the getDataLen method for ShuffleDataResult (
a1bcc1b 
#1170)

### What changes were proposed in this pull request?

Exposing `ShuffleDataResult.getDataLen` method for being invoked by metrics and tests.

### Why are the changes needed?

Exposing `ShuffleDataResult.getDataLen` method for being invoked by metrics and tests.

Fix: #1164 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

No need.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pegasas pegasas

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1164] refactor: Exposing the getDataLen method for ShuffleDataResult pegasas/incubator-uniffle
2 participants
@jerqi @pegasas