Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Uniformly throw RssException for external callers #1549

Closed
3 tasks done
rickyma opened this issue Feb 28, 2024 · 0 comments
Closed
3 tasks done

[Bug] Uniformly throw RssException for external callers #1549

rickyma opened this issue Feb 28, 2024 · 0 comments

Comments

@rickyma
Copy link
Contributor

rickyma commented Feb 28, 2024

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

We need to uniformly throw RssException for external callers, making it convenient for them to perform unified exception handling.

For example , as described in #888, we can uniformly handle RssException in Spark's TaskSetManager.

Some custom exception classes in the rss-common module directly inherit from RuntimeException, instead of RssException. Since the rss-common module can be directly used by clients, we need to fix this issue.

Affects Version(s)

master

Uniffle Server Log Output

No response

Uniffle Engine Log Output

No response

Uniffle Server Configurations

No response

Uniffle Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
rickyma added a commit to rickyma/incubator-uniffle that referenced this issue Feb 28, 2024
@rickyma
[apache#1549] fix(common): Uniformly throw RssException for external …
b1884f9 
…callers
@rickyma rickyma mentioned this issue Feb 28, 2024
Merged
jerqi pushed a commit that referenced this issue Feb 28, 2024
@rickyma
[#1549] fix(common): Uniformly throw RssException for external callers (
d4c0fc5 
#1550)

### What changes were proposed in this pull request?

Make custom exception classes in the `rss-common` module inherit from `RssException`.

### Why are the changes needed?

For #1549

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing UTs.
@jerqi jerqi closed this as completed Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jerqi @rickyma