Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] previous data is not deleted when re-register shuffle after re-assignment for stage recomputing #1579

Closed
3 tasks done
zuston opened this issue Mar 14, 2024 · 0 comments · Fixed by #1762 · May be fixed by #1584
Closed
3 tasks done

[Bug] previous data is not deleted when re-register shuffle after re-assignment for stage recomputing #1579

zuston opened this issue Mar 14, 2024 · 0 comments · Fixed by #1762 · May be fixed by #1584
Milestone
0.10.0

Comments

@zuston
Copy link
Member

zuston commented Mar 14, 2024

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

previous data is not deleted when re-register shuffle after re-assignment for stage recomputing

Affects Version(s)

master

Uniffle Server Log Output

No response

Uniffle Engine Log Output

No response

Uniffle Server Configurations

No response

Uniffle Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
zuston added a commit to zuston/incubator-uniffle that referenced this issue Mar 15, 2024
@zuston
[apache#1579] fix(spark): clear out previous stage attempt data synch…
17944ab 
…ronously
zuston added a commit to zuston/incubator-uniffle that referenced this issue Mar 15, 2024
@zuston
[apache#1579] fix(spark): clear out previous stage attempt data synch…
1c0710a 
…ronously
@zuston zuston mentioned this issue Mar 15, 2024
Open
zuston added a commit to zuston/incubator-uniffle that referenced this issue Mar 22, 2024
@zuston
[apache#1579] fix(spark): clear out previous stage attempt data synch…
b192095 
…ronously for stage resubmit
zuston added a commit to zuston/incubator-uniffle that referenced this issue Mar 22, 2024
@zuston
[apache#1579] fix(spark): clear out previous stage attempt data synch…
4d3a892 
…ronously for stage resubmit
zuston added a commit to zuston/incubator-uniffle that referenced this issue Mar 26, 2024
@zuston
[apache#1579][part-2] feat(spark): allow to register shuffle in parallel
4d4dc7a
@zuston zuston mentioned this issue Mar 26, 2024
Closed
yl09099 pushed a commit to zuston/incubator-uniffle that referenced this issue May 12, 2024
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
34de6be 
…at all previous data is cleared for stage retry
yl09099 pushed a commit to zuston/incubator-uniffle that referenced this issue May 12, 2024
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
a4eb480 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 12, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
2dff9da 
…at all previous data is cleared for stage retry
yl09099 pushed a commit to zuston/incubator-uniffle that referenced this issue May 12, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
c867c4c 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 13, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
d8235a7 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 13, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
ecb2fb2 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 13, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
6cca4c4 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 13, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
b7585a6 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 13, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
1c27704 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 13, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
0ebc30b 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 14, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
2e9f96e 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 15, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
ad9f590 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 15, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
af3264f 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 15, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
57894b5 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 16, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
7483dc0 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 16, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
b44855b 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 16, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
42b074d 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 16, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
14e6a83 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 16, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
690e5b4 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 17, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
4c4ec92 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 17, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
01113b6 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 17, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
5e34bf2 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 18, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
c5e4e27 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 21, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
ae02409 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 23, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
fa40ceb 
…at all previous data is cleared for stage retry
@zuston zuston added this to the 0.10.0 milestone May 23, 2024
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 24, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
5ef5498 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 24, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
595750b 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 24, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
634109d 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 24, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
5f62b1b 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 24, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
522926d 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 24, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
5c9d9e3 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue May 24, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
3dd6b34 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue Jun 3, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
8db08bf 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue Jun 3, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
a8b70cc 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue Jun 3, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
10bc42c 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue Jun 3, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
d1da077 
…at all previous data is cleared for stage retry
yl09099 added a commit to zuston/incubator-uniffle that referenced this issue Jun 3, 2024
@yl09099
[apache#1579][part-1] fix(spark): Split Stage retry and Block retry.
61e2a9b
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 3, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
de11765 
…at all previous data is cleared for stage retry.
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 3, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
2c7329b 
…at all previous data is cleared for stage retry.
@yl09099 yl09099 mentioned this issue Jun 3, 2024
Merged
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 3, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
500219a 
…at all previous data is cleared for stage retry.
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 3, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
3626381 
…at all previous data is cleared for stage retry.
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 4, 2024
@yl09099
[apache#1579][part-1] fix(spark): Re-registration is not performed if…
64f5945 
… the data in the previous Stage fails to be cleared.
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 4, 2024
@yl09099
[apache#1579][part-1] fix(spark): Re-registration is not performed if…
f5ba339 
… the data in the previous Stage fails to be cleared.
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 5, 2024
@yl09099
[apache#1579][part-1] fix(spark):Registration failed quickly before S…
652293b 
…tage retry.
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 5, 2024
@yl09099
[apache#1579][part-1] fix(spark):Registration failed quickly before S…
72c0322 
…tage retry.
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 8, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
b43d6e3 
…at all previous data is cleared for stage retry.
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 8, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
2aca4a6 
…at all previous data is cleared for stage retry.
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 12, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
1a215dc 
…at all previous data is cleared for stage retry.
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 12, 2024
@yl09099
[apache#1579][part-1] fix(spark): Adjust reassigned time to ensure th…
451718c 
…at all previous data is cleared for stage retry.
zuston pushed a commit that referenced this issue Jun 13, 2024
@yl09099
[#1579][part-1] fix(spark): Ensure all previous data is cleared for s…
375262a 
…tage retry (#1762)

### What changes were proposed in this pull request?

1. clear out previous stage attempt data synchronously when registering the re-assignment shuffleIds.
2. rework the stage retry interface and rpc
3. introducing the stage version to avoid accepting the older data

### Why are the changes needed?

Fix: #1579

If the previous stage attempt is in the purge queue in shuffle-server side, the retry stage writing will cause
unknown exceptions, so we'd better to clear out all previous stage attempt data before re-registering

This PR is to sync remove previous stage data when the first attempt writer is initialized.

Does this PR introduce any user-facing change?

No.

### How was this patch tested?

Existing tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0
1 participant
@zuston