Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix flaky tests #1662

Closed
3 tasks done
rickyma opened this issue Apr 19, 2024 · 0 comments · Fixed by #1663
Closed
3 tasks done

[Bug] Fix flaky tests #1662

rickyma opened this issue Apr 19, 2024 · 0 comments · Fixed by #1663

Comments

@rickyma
Copy link
Contributor

rickyma commented Apr 19, 2024

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

We can see flaky tests like https://github.com/apache/incubator-uniffle/actions/runs/8747823784/job/24006888103?pr=1661.
Because #1653 has been put on hold. So I'll cherry-pick the code from #1653.

Affects Version(s)

master

Uniffle Server Log Output

No response

Uniffle Engine Log Output

No response

Uniffle Server Configurations

No response

Uniffle Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@rickyma rickyma changed the title [Bug] Fix flaky tests [Bug] Fix flaky tests and update Netty related docs Apr 19, 2024
@rickyma rickyma changed the title [Bug] Fix flaky tests and update Netty related docs [Bug] Fix flaky tests and update docs Apr 19, 2024
rickyma added a commit to rickyma/incubator-uniffle that referenced this issue Apr 19, 2024
@rickyma
[apache#1662] fix(test): Fix flaky tests
f49cfe2
@rickyma rickyma mentioned this issue Apr 19, 2024
Merged
rickyma added a commit to rickyma/incubator-uniffle that referenced this issue Apr 19, 2024
@rickyma
[apache#1662] fix(test): Fix flaky tests
19d84cf
rickyma added a commit to rickyma/incubator-uniffle that referenced this issue Apr 19, 2024
@rickyma
[apache#1662] fix(test): Fix flaky tests
0f721dc
rickyma added a commit to rickyma/incubator-uniffle that referenced this issue Apr 19, 2024
@rickyma
[apache#1662] fix(test): Fix flaky tests
3f5d5da
rickyma added a commit to rickyma/incubator-uniffle that referenced this issue Apr 19, 2024
@rickyma
[apache#1662] fix(test): Fix flaky tests
e13fe8f
@rickyma rickyma changed the title [Bug] Fix flaky tests and update docs [Bug] Fix flaky tests Apr 19, 2024
zuston pushed a commit that referenced this issue Apr 25, 2024
@rickyma
[#1662] fix(test): Fix Netty related flaky tests (#1663)
3bc0ee5 
### What changes were proposed in this pull request?

Fix some flaky tests.

### Why are the changes needed?

Fix: #1662.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Unnecessary.
jerqi pushed a commit that referenced this issue Apr 30, 2024
@rickyma
[#1662] fix(test): Fix Netty related flaky tests (#1663)
51a2639 
### What changes were proposed in this pull request?

Fix some flaky tests.

### Why are the changes needed?

Fix: #1662.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Unnecessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1662] fix(test): Fix Netty related tests rickyma/incubator-uniffle
1 participant
@rickyma