-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Eliminate raw use of parameterized class #417
Labels
good first issue
Good for newcomers
Comments
Hi @advancedxy I'd like to handle this issue if you agreed. Thank you. |
I assigned to you. |
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
May 19, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
May 19, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
May 19, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
May 19, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
May 19, 2023
…orrect indentation level 4, expected level should be one of the following: 6, 8, 10. [Indentation]
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
May 23, 2023
… Class<? extends Throwable>
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
May 23, 2023
… HashMap<String, Object>
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
May 23, 2023
…ject>' with ConcurrentHashMap<Obejct, Object>
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
May 23, 2023
…orrect indentation level 4, expected level should be one of the following: 6, 8, 10. [Indentation]
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
May 24, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
May 24, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
May 24, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
May 24, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
May 24, 2023
…orrect indentation level 4, expected level should be one of the following: 6, 8, 10. [Indentation]
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
May 24, 2023
… Class<? extends Throwable>
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
May 24, 2023
… HashMap<String, Object>
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
May 24, 2023
…ject>' with ConcurrentHashMap<Obejct, Object>
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
May 24, 2023
…orrect indentation level 4, expected level should be one of the following: 6, 8, 10. [Indentation]
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
May 26, 2023
jerqi
pushed a commit
that referenced
this issue
May 28, 2023
### What changes were proposed in this pull request? Eliminate `raw use of parameterized class` ### Why are the changes needed? Fix: #417 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? current UT
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
Jul 12, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
Jul 14, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
Jul 14, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
Jul 16, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
Jul 16, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
Jul 16, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
Jul 27, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
Jul 27, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
Jul 27, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
Jul 27, 2023
…torClientFactory singleton
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
Jul 27, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
Jul 29, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
Jul 29, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
Jul 29, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
Aug 8, 2023
…torClientFactory singleton
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
Aug 8, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
Aug 8, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
Aug 8, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
Aug 8, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
Aug 11, 2023
…torClientFactory singleton
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
Aug 11, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
Aug 11, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
Aug 11, 2023
cchung100m
added a commit
to cchung100m/incubator-uniffle
that referenced
this issue
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Code of Conduct
Search before asking
What would you like to be improved?
When I'm browsing the Uniffle codebase, a lot of raw use of parameterized class occurred, especially in test classes.
For instance, the
iterator
parameter andproduct2
variable is raw use of parameterized classincubator-uniffle/client-spark/common/src/test/java/org/apache/spark/shuffle/reader/AbstractRssReaderTest.java
Lines 51 to 63 in 66c752f
How should we improve?
Eliminate the raw use of parameterized class as much as possible.
Are you willing to submit PR?
The text was updated successfully, but these errors were encountered: