Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Don't delete base storage path if it's already an empty dir #571

Closed
3 tasks done
advancedxy opened this issue Feb 9, 2023 · 0 comments · Fixed by #573
Closed
3 tasks done

[Improvement] Don't delete base storage path if it's already an empty dir #571

advancedxy opened this issue Feb 9, 2023 · 0 comments · Fixed by #573

Comments

@advancedxy
Copy link
Contributor

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Skip delete base storage if it's already an empty dir.

How should we improve?

When deploying on containerized environment, such as K8S. base path maybe mounted by the platform, and it cannot be removed.

When the base directory is already an empty dir, we don't have to rm the directory and recreated again.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@advancedxy advancedxy mentioned this issue Feb 9, 2023
Merged
advancedxy added a commit that referenced this issue Feb 9, 2023
@advancedxy
[#571] feat: skip init for empty writable base dir (#573)
7dcaeeb 
### What changes were proposed in this pull request?
Skip init empty and writable base dir

### Why are the changes needed?
In some deployment env, base dir could be a mount point
This fixes #571

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Added UT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#571] feat: skip init for empty writable base dir advancedxy/incubator-uniffle
1 participant
@advancedxy