Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] [Netty] Writer support off heap memory to compress data #593

Open
2 of 3 tasks
Tracked by #133
jerqi opened this issue Feb 10, 2023 · 2 comments · Fixed by #830 or #857 · May be fixed by #861
Open
2 of 3 tasks
Tracked by #133

[Subtask] [Netty] Writer support off heap memory to compress data #593

jerqi opened this issue Feb 10, 2023 · 2 comments · Fixed by #830 or #857 · May be fixed by #861
Assignees
@xumanbu

Comments

@jerqi
Copy link
Contributor

jerqi commented Feb 10, 2023

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the subtask

Writer support off heap memory to compress data. And we use the off heap memory to send data.

Parent issue

#133

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@jerqi jerqi changed the title [Subtask] Writer support off heap memory to compress data [Subtask] [Netty] Writer support off heap memory to compress data Feb 10, 2023
@jerqi jerqi mentioned this issue Feb 22, 2023
Closed
21 tasks
@xumanbu
Copy link
Contributor

xumanbu commented Mar 1, 2023

assgin for me,thx

xumanbu added a commit to xumanbu/incubator-uniffle that referenced this issue Apr 19, 2023
@xumanbu
[apache#593][part-1]feat:Codec compress support ByteBuffer
7595538
@xumanbu xumanbu mentioned this issue Apr 19, 2023
Merged
xumanbu added a commit to xumanbu/incubator-uniffle that referenced this issue Apr 19, 2023
@xumanbu
[apache#593][part-1]Codec add maxCompressedLength function
4264500
advancedxy pushed a commit that referenced this issue Apr 24, 2023
@xumanbu
[#593][part-1] feat: Codec compress support ByteBuffer (#830)
4a17a58 
### What changes were proposed in this pull request?
1. Codec add `ByteBuffer` type compress.

### Why are the changes needed?
Fix: #593

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
UT
@jerqi jerqi reopened this Apr 24, 2023
@jerqi
Copy link
Contributor Author

jerqi commented Apr 24, 2023

Only some parts have been finished. Reopen.

@xumanbu xumanbu mentioned this issue May 9, 2023
Merged
xumanbu added a commit to xumanbu/incubator-uniffle that referenced this issue May 10, 2023
@xumanbu
[apache#593][part-2]feat:WriteBuffer use ByteBuf
bb99cae
@xumanbu xumanbu linked a pull request May 10, 2023 that will close this issue
Open
jerqi pushed a commit that referenced this issue May 10, 2023
@xumanbu
[#593][FOLLOWUP] Fix zstd compress dest ByteBuffer position
1ea1f1b 
### What changes were proposed in this pull request?
Fix Zstd compress dest ByteBuffer position

### Why are the changes needed?
ZstdCodec compress method called with src&dest on Heap ByteBuffer, the dest ByteBuffer position will not update. should keep consistent with others Codec.

Fix: #593

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

UT

Co-authored-by: jam.xu <jam.xu@vipshop.com>
@jerqi jerqi reopened this May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xumanbu xumanbu

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jerqi @xumanbu