Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] feat(operator): Support for custom initialization parameters. #645

Closed
3 tasks done
crain-cn opened this issue Feb 22, 2023 · 5 comments · Fixed by #670
Closed
3 tasks done

[Improvement] feat(operator): Support for custom initialization parameters. #645

crain-cn opened this issue Feb 22, 2023 · 5 comments · Fixed by #670

Comments

@crain-cn
Copy link
Contributor

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

I want to support the InitFlags method in main.go, which can modify the Options setting of the Manager to customize many properties.

How should we improve?

We should add an InitFlags method in main.go, and then use flag package to set default parameters to accept command-line arguments. This allows users to customize various startup parameters and configurations easily.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@zuston
Copy link
Member

zuston commented Feb 27, 2023

PTAL @advancedxy @wangao1236

@advancedxy
Copy link
Contributor

advancedxy commented Feb 27, 2023 •
edited
Loading

From the issue description, I don't quite get what you want to archive. The main.go for controller and webhook already handles flag parsing.

But you are always welcome to submit a PR, and let's discuss there.

@crain-cn
Copy link
Contributor Author

From the issue description, I don't quite get what you want to archive. The main.go for controller and webhook already handles flag parsing.

But you are always welcome to submit a PR, and let's discuss there.

Only the parameters in Config are configured, and parameters in ctrl.Options such as SyncPeriod, Namespace, and RetryPeriod cannot be modified.

@advancedxy
Copy link
Contributor

From the issue description, I don't quite get what you want to archive. The main.go for controller and webhook already handles flag parsing.
But you are always welcome to submit a PR, and let's discuss there.

Only the parameters in Config are configured, and parameters in ctrl.Options such as SyncPeriod, Namespace, and RetryPeriod cannot be modified.

I see. SGTM.

@crain-cn crain-cn mentioned this issue Feb 28, 2023
Merged
@crain-cn
Copy link
Contributor Author

From the issue description, I don't quite get what you want to archive. The main.go for controller and webhook already handles flag parsing.
But you are always welcome to submit a PR, and let's discuss there.

Only the parameters in Config are configured, and parameters in ctrl.Options such as SyncPeriod, Namespace, and RetryPeriod cannot be modified.

I see. SGTM.

Submitted. #670

advancedxy pushed a commit that referenced this issue Mar 5, 2023
@crain-cn
[#645][Improvement] feat(operator): support manager parameter configu…
a6365cb 
…ration (#670)

### What changes were proposed in this pull request?
 Support Operator Manager parameter configuration.

### Why are the changes needed?
 1.  It is possible to customize parameters and modify the required configuration parameters.
 2. Hope to make reasonable use of Kubernetes services.

Closes #645

### Does this PR introduce _any_ user-facing change?
Because in real-world scenarios, it may be necessary to adjust some parameters, such as Namespace.

### How was this patch tested?
Manually verified.
![image](https://user-images.githubusercontent.com/45311215/221807077-9b07f00d-e88e-4cea-894c-935f4096a1e7.png)
advancedxy pushed a commit to advancedxy/incubator-uniffle that referenced this issue Mar 21, 2023
@crain-cn @advancedxy
[apache#645][Improvement] feat(operator): support manager parameter c…
0098c06 
…onfiguration (apache#670)

### What changes were proposed in this pull request?
 Support Operator Manager parameter configuration.

### Why are the changes needed?
 1.  It is possible to customize parameters and modify the required configuration parameters.
 2. Hope to make reasonable use of Kubernetes services.

Closes apache#645

### Does this PR introduce _any_ user-facing change?
Because in real-world scenarios, it may be necessary to adjust some parameters, such as Namespace.

### How was this patch tested?
Manually verified.
![image](https://user-images.githubusercontent.com/45311215/221807077-9b07f00d-e88e-4cea-894c-935f4096a1e7.png)
xianjingfeng pushed a commit to xianjingfeng/incubator-uniffle that referenced this issue Apr 5, 2023
@crain-cn
[apache#645][Improvement] feat(operator): support manager parameter c…
a1937a1 
…onfiguration (apache#670)

### What changes were proposed in this pull request?
 Support Operator Manager parameter configuration.

### Why are the changes needed?
 1.  It is possible to customize parameters and modify the required configuration parameters.
 2. Hope to make reasonable use of Kubernetes services.

Closes apache#645

### Does this PR introduce _any_ user-facing change?
Because in real-world scenarios, it may be necessary to adjust some parameters, such as Namespace.

### How was this patch tested?
Manually verified.
![image](https://user-images.githubusercontent.com/45311215/221807077-9b07f00d-e88e-4cea-894c-935f4096a1e7.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@advancedxy @zuston @crain-cn