Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] polish start-coordinator.sh #655

Closed
3 tasks done
advancedxy opened this issue Feb 24, 2023 · 0 comments · Fixed by #656
Closed
3 tasks done

[Improvement] polish start-coordinator.sh #655

advancedxy opened this issue Feb 24, 2023 · 0 comments · Fixed by #656

Comments

@advancedxy
Copy link
Contributor

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

  1. add gc log for coordinator
  2. makes heap size configurable

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@advancedxy advancedxy mentioned this issue Feb 24, 2023
Merged
advancedxy added a commit that referenced this issue Feb 24, 2023
@advancedxy
feat(coordinator): heap size configurable and add gc log (#656)
18c738e 
### What changes were proposed in this pull request?
1. make heap size of coordinator configurable
2. add gc log for coordinator

### Why are the changes needed?
1. heap size configurable otherwise, there's no point to set it in the rss spec
2. gc log: for better logging
3. Fix: #655

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
No need
xianjingfeng pushed a commit to xianjingfeng/incubator-uniffle that referenced this issue Apr 5, 2023
@advancedxy
feat(coordinator): heap size configurable and add gc log (apache#656)
bbb0d82 
### What changes were proposed in this pull request?
1. make heap size of coordinator configurable
2. add gc log for coordinator

### Why are the changes needed?
1. heap size configurable otherwise, there's no point to set it in the rss spec
2. gc log: for better logging
3. Fix: apache#655

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
No need
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#655]feat(coordinator): heap size configurable and add gc log advancedxy/incubator-uniffle
1 participant
@advancedxy