Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Umbrella] Cleanup residue files in tmp directory after tests #722

Closed
2 of 7 tasks
kaijchen opened this issue Mar 15, 2023 · 0 comments · Fixed by #1134
Closed
2 of 7 tasks

[Umbrella] Cleanup residue files in tmp directory after tests #722

kaijchen opened this issue Mar 15, 2023 · 0 comments · Fixed by #1134

Comments

@kaijchen
Copy link
Contributor

kaijchen commented Mar 15, 2023 •
edited

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the proposal

There are many residue files in tmp directory after tests.
Sometimes it will cause issues in repeated tests or parallel tests.
We can use JUnit 5 managed @TempDir to replace Files.createTempDirectory().

$ mvn clean package -Pspark3
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  21:06 min
[INFO] Finished at: 2023-03-15T14:36:19+08:00
[INFO] ------------------------------------------------------------------------
$ find | grep '/target/tmp/'
./integration-test/spark-common/target/tmp/dynamicConf5843229430228465171conf
./integration-test/spark-common/target/tmp/rss62430369913332225
./integration-test/spark-common/target/tmp/dynamicConf6147274175500176169conf
./integration-test/spark-common/target/tmp/dynamicConf4208328593701611930conf
./integration-test/spark-common/target/tmp/rss562630552492365514
./integration-test/spark-common/target/tmp/rss46277087768255567
./integration-test/spark-common/target/tmp/dynamicConf1817755823767020171conf
./integration-test/spark-common/target/tmp/rss8341883984735558073
./integration-test/spark-common/target/tmp/dynamicConf8701841393224148370conf
./integration-test/spark-common/target/tmp/rss1030728888778640567
./integration-test/spark-common/target/tmp/dynamicConf5751228400475518214conf
./integration-test/spark-common/target/tmp/dynamicConf919596028861517530conf
./integration-test/spark-common/target/tmp/dynamicConf2112348039475291387conf
./integration-test/spark-common/target/tmp/dynamicConf8968200515884439551conf
./integration-test/spark-common/target/tmp/spark-1b6fb52c-382a-4666-a743-01fe376a9da3
./integration-test/spark-common/target/tmp/dynamicConf3642606138147557145conf
./integration-test/spark-common/target/tmp/dynamicConf7764795188572170812conf
./integration-test/spark-common/target/tmp/rss1340437940162131196
./integration-test/spark3/target/tmp/rssdata4683867891894737544
./integration-test/spark3/target/tmp/rssdata4683867891894737544/local-1678862145522_1678862145477
./integration-test/spark3/target/tmp/rssdata4683867891894737544/local-1678862145522_1678862145477/1
./integration-test/spark3/target/tmp/rssdata4683867891894737544/local-1678862145522_1678862145477/1/92-92
./integration-test/spark3/target/tmp/rssdata4683867891894737544/local-1678862145522_1678862145477/1/92-92/9.134.131.52-20001.data
./integration-test/spark3/target/tmp/rssdata4683867891894737544/local-1678862145522_1678862145477/1/92-92/9.134.131.52-20001.index
...
./integration-test/spark3/target/tmp/rssdata4683867891894737544/local-1678862145522_1678862145477/0/6-6
./integration-test/spark3/target/tmp/rssdata4683867891894737544/local-1678862145522_1678862145477/0/6-6/9.134.131.52-20001.data
./integration-test/spark3/target/tmp/rssdata4683867891894737544/local-1678862145522_1678862145477/0/6-6/9.134.131.52-20001.index
./integration-test/spark3/target/tmp/dynamicConf4726090287767810753conf
./integration-test/spark3/target/tmp/dynamicConf7395142600914379199conf
./integration-test/spark3/target/tmp/dynamicConf5485162686795986256conf
./integration-test/spark3/target/tmp/spark-43b4179d-9940-4625-a2bf-f87bbe86ccbb
./storage/target/tmp/dummy-data-file7618350169586815030.index
./storage/target/tmp/dummy-data-file1719959362551363828.data
./client-spark/spark3/target/tmp/spark-18439b64-6f95-49ed-98b9-46053929202e
./server/target/tmp/removeShuffleDataWithLocalfileTest8262825757764355506
./server/target/tmp/removeShuffleDataWithLocalfileTest8262825757764355506/removeShuffleDataWithLocalfileTest
./server/target/tmp/removeShuffleDataWithLocalfileTest5796962123722765961
./server/target/tmp/removeShuffleDataWithLocalfileTest5796962123722765961/removeShuffleDataWithLocalfileTest
./common/target/tmp/rss3072326445112259054

Task list

  • residue files of unit tests
  • residue files of spark3 integration tests
  • residue files of spark2 integration tests
  • residue files of mr integration tests

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
kaijchen added a commit to kaijchen/incubator-uniffle that referenced this issue Mar 15, 2023
@kaijchen
[apache#722] test: use JUnit 5 TempDir to avoid residue
f487cb8
cchung100m added a commit to cchung100m/incubator-uniffle that referenced this issue Aug 11, 2023
@cchung100m
[apache#722] imporvement: update the coordinatorAssignmentTest.java
6222532
cchung100m added a commit to cchung100m/incubator-uniffle that referenced this issue Aug 11, 2023
@cchung100m
[apache#722] imporvement: Cleanup residue files in tmp directory afte…
ea64ead 
…r tests
@cchung100m cchung100m mentioned this issue Aug 11, 2023
Merged
cchung100m added a commit to cchung100m/incubator-uniffle that referenced this issue Aug 19, 2023
@cchung100m
[apache#722] imporvement: Cleanup residue files in tmp directory afte…
193340d 
…r tests
cchung100m added a commit to cchung100m/incubator-uniffle that referenced this issue Aug 19, 2023
@cchung100m
[apache#722] revert the common/src/test/java/org/apache/uniffle/commo…
9e6e6bc 
…n/KerberizedHadoop.java
cchung100m added a commit to cchung100m/incubator-uniffle that referenced this issue Aug 19, 2023
@cchung100m
[apache#722] imporvement: Cleanup residue files in tmp directory afte…
5790273 
…r tests
cchung100m added a commit to cchung100m/incubator-uniffle that referenced this issue Aug 19, 2023
@cchung100m
[apache#722] revert the 'BeforeEach'
d072915
cchung100m added a commit to cchung100m/incubator-uniffle that referenced this issue Aug 19, 2023
@cchung100m
[apache#722] improvement: Cleanup residue files in tmp directory afte…
0415f42 
…r tests
cchung100m added a commit to cchung100m/incubator-uniffle that referenced this issue Aug 19, 2023
@cchung100m
[apache#722] improvement: Cleanup residue files in tmp directory for …
80c3f24 
…integration-test/spark3
cchung100m added a commit to cchung100m/incubator-uniffle that referenced this issue Aug 19, 2023
@cchung100m
[apache#722] improvement: Cleanup residue files in tmp directory for …
9c01d9f 
…integration-test/spark-common
kaijchen pushed a commit that referenced this issue Aug 21, 2023
@cchung100m
[#722] test: cleanup residue files in tmp directory after tests (#1134)
76559ce 
### What changes were proposed in this pull request?

Cleanup residue files in tmp directory after tests

### Why are the changes needed?

Fix: #722 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

current UT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#722] test: cleanup residue files in tmp directory after tests cchung100m/incubator-uniffle
1 participant
@kaijchen