Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Add the method of creating thread pool #755

Closed
3 tasks done
smallzhongfeng opened this issue Mar 23, 2023 · 0 comments · Fixed by #767
Closed
3 tasks done

[Improvement] Add the method of creating thread pool #755

smallzhongfeng opened this issue Mar 23, 2023 · 0 comments · Fixed by #767

Comments

@smallzhongfeng
Copy link
Contributor

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

The current method for creating thread pools is not uniform, and tool classes are used to unify them.

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
smallzhongfeng added a commit to smallzhongfeng/incubator-uniffle that referenced this issue Mar 24, 2023
@smallzhongfeng
apache#755 improvement: Add the method of creating thread pool
d11f82e
smallzhongfeng added a commit to smallzhongfeng/incubator-uniffle that referenced this issue Mar 24, 2023
@smallzhongfeng
apache#755 improvement: Add the method of creating thread pool
7452d9c
smallzhongfeng added a commit to smallzhongfeng/incubator-uniffle that referenced this issue Mar 27, 2023
@smallzhongfeng
apache#755 improvement: Add the method of creating thread pool
55007ea
@smallzhongfeng smallzhongfeng mentioned this issue Mar 27, 2023
Merged
smallzhongfeng added a commit that referenced this issue Mar 28, 2023
@smallzhongfeng
[#755] refactor: Add the method of creating thread pool (#767)
3f9ba81 
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
   https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?
Four util methods for creating thread pools have been added.

### Why are the changes needed?
Fix: #755

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Origin uts.
xianjingfeng pushed a commit to xianjingfeng/incubator-uniffle that referenced this issue Apr 5, 2023
@smallzhongfeng
[apache#755] refactor: Add the method of creating thread pool (apache…
793435f 
…#767)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[apache#123] feat(operator): support xxx"
     - "[apache#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[apache#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
   https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?
Four util methods for creating thread pools have been added.

### Why are the changes needed?
Fix: apache#755

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Origin uts.
@zhengchenyu zhengchenyu mentioned this issue Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#755] refactor: Add the method of creating thread pool smallzhongfeng/incubator-uniffle
1 participant
@smallzhongfeng