Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Failed to obtain constructor for MetricReporter #796

Closed
3 tasks done
xianjingfeng opened this issue Apr 4, 2023 · 0 comments · Fixed by #797
Closed
3 tasks done

[Bug] Failed to obtain constructor for MetricReporter #796

xianjingfeng opened this issue Apr 4, 2023 · 0 comments · Fixed by #797

Comments

@xianjingfeng
Copy link
Member

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

[ERROR] 2023-04-04 09:09:57,810 main ShuffleServer <init> - Errors on initializing shuffle server.
java.lang.NoSuchMethodException: org.apache.uniffle.common.metrics.prometheus.PrometheusPushGatewayMetricReporter.<init>(org.apache.uniffle.server.ShuffleServerConf, java.lang.String)
        at java.lang.Class.getConstructor0(Class.java:3082)
        at java.lang.Class.getConstructor(Class.java:1825)
        at org.apache.uniffle.common.metrics.MetricReporterFactory.getMetricReporter(MetricReporterFactory.java:36)
        at org.apache.uniffle.server.ShuffleServer.registerMetrics(ShuffleServer.java:247)
        at org.apache.uniffle.server.ShuffleServer.initialization(ShuffleServer.java:171)
        at org.apache.uniffle.server.ShuffleServer.<init>(ShuffleServer.java:85)

Affects Version(s)

master

Uniffle Server Log Output

No response

Uniffle Engine Log Output

No response

Uniffle Server Configurations

No response

Uniffle Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@xianjingfeng xianjingfeng mentioned this issue Apr 5, 2023
Merged
xianjingfeng added a commit that referenced this issue Apr 7, 2023
@xianjingfeng
[#796] bug:fix the issues of MetricReporter (#797)
410dcc0 
### What changes were proposed in this pull request?
Support custom config keys defined in plugins
Refactor the logic for load config file
Fix some issues of metricReporter.
### Why are the changes needed?
Metric reporter is unusable.
Fix: #796

### Does this PR introduce any user-facing change?
No.

### How was this patch tested?
UT and Manual testing
xianjingfeng added a commit to xianjingfeng/incubator-uniffle that referenced this issue Apr 13, 2023
@xianjingfeng
[apache#796] bug:fix the issues of MetricReporter (apache#797)
0507c87 
### What changes were proposed in this pull request?
Support custom config keys defined in plugins
Refactor the logic for load config file
Fix some issues of metricReporter.
### Why are the changes needed?
Metric reporter is unusable.
Fix: apache#796

### Does this PR introduce any user-facing change?
No.

### How was this patch tested?
UT and Manual testing
# Conflicts:
#	common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java
#	server/src/test/java/org/apache/uniffle/server/ShuffleServerConfTest.java
@xianjingfeng xianjingfeng mentioned this issue Apr 13, 2023
Merged
xianjingfeng added a commit that referenced this issue Apr 13, 2023
@xianjingfeng
[#796][0.7] bug: Fix the issues of MetricReporter (#821)
bcb591e 
### What changes were proposed in this pull request?
1.Support custom config keys defined in plugins
2.Refactor the logic for load config file
3.Fix some issues of metricReporter.
### Why are the changes needed?
Metric reporter is unusable.
Fix: #796

### Does this PR introduce any user-facing change?
No.

### How was this patch tested?
UT and Manual testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#796] bug:fix the issues of MetricReporter xianjingfeng/incubator-uniffle
1 participant
@xianjingfeng