Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Optimize CRC calculation of ByteBuffer #804

Closed
3 tasks done
Tracked by #133
jerqi opened this issue Apr 8, 2023 · 0 comments · Fixed by #805
Closed
3 tasks done
Tracked by #133

[Improvement] Optimize CRC calculation of ByteBuffer #804

jerqi opened this issue Apr 8, 2023 · 0 comments · Fixed by #805

Comments

@jerqi
Copy link
Contributor

jerqi commented Apr 8, 2023

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

When we calculate the crc value, we need to copy data to byte array, it's unnecessary. We will use off heap memory in the v 0.8. So CRC calculation should support off heap memory totally.

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@jerqi jerqi mentioned this issue Apr 8, 2023
Closed
21 tasks
jerqi added a commit to jerqi/incubator-uniffle that referenced this issue Apr 8, 2023
@jerqi
[apache#804] improvement: Optimize CRC calculation of ByteBuffer
7380ca3
@jerqi jerqi mentioned this issue Apr 8, 2023
Merged
jerqi added a commit that referenced this issue Apr 10, 2023
@jerqi
[#804] improvement: Optimize CRC calculation of ByteBuffer (#805)
cae7cd9 
### What changes were proposed in this pull request?
1. remove unnecessary methods
2. Optimize crc method

### Why are the changes needed?

Fix: #804

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
New ut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#804] improvement: Optimize CRC calculation of ByteBuffer jerqi/incubator-uniffle
1 participant
@jerqi