Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Support generating HPA objects #827

Closed
3 tasks done
wangao1236 opened this issue Apr 18, 2023 · 0 comments · Fixed by #828
Closed
3 tasks done

[FEATURE] Support generating HPA objects #827

wangao1236 opened this issue Apr 18, 2023 · 0 comments · Fixed by #828
Assignees
@wangao1236

Comments

@wangao1236
Copy link
Collaborator

wangao1236 commented Apr 18, 2023 •
edited
Loading

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the feature

We need to support ShuffleServer to use HPA objects to achieve horizontal automatic scaling.

Motivation

No response

Describe the solution

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@wangao1236 wangao1236 self-assigned this Apr 18, 2023
@wangao1236 wangao1236 changed the title [FEATURE] [FEATURE] Support generating HPA objects Apr 18, 2023
@wangao1236 wangao1236 mentioned this issue Apr 18, 2023
Merged
jerqi pushed a commit that referenced this issue Apr 21, 2023
@wangao1236
[#827] feat(operator): support generating hpa objects (#828)
893e4ee 
### What changes were proposed in this pull request?

In this PR, we will be adding the Autoscaler field for the first time in the CRD, enabling users to support ShuffleServer using the HPA object to achieve horizontal automatic scaling.

In the next PR, we will provide more detailed documentation to explain the format and usage examples of .spec.shuffleServer.autoscaler field.

### Why are the changes needed?

Fix: #827

### Does this PR introduce _any_ user-facing change?

If users need to use the automatic scaling feature, they need to edit the .spec.shuffleServer.autoscaler field, which is completely identical to the .spec field definition of kubernetes' HPA object.

### How was this patch tested?

Manually verified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wangao1236 wangao1236

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#827] feat(operator): support generating hpa objects wangao1236/incubator-uniffle
1 participant
@wangao1236