Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] Display information of all application through Cli #837

Closed
3 tasks done
Tracked by #758
smallzhongfeng opened this issue Apr 21, 2023 · 3 comments · Fixed by #964
Closed
3 tasks done
Tracked by #758

[Subtask] Display information of all application through Cli #837

smallzhongfeng opened this issue Apr 21, 2023 · 3 comments · Fixed by #964
Assignees
@slfan1989

Comments

@smallzhongfeng
Copy link
Contributor

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the subtask

Display the information of all servers through the Cli command such as uniffle-cli --list application

Parent issue

#758

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@smallzhongfeng smallzhongfeng mentioned this issue Apr 21, 2023
Open
9 tasks
@slfan1989
Copy link
Collaborator

@smallzhongfeng Can you assign this issue to me? Thank you very much!

@slfan1989 slfan1989 mentioned this issue Apr 27, 2023
Merged
@jerqi
Copy link
Contributor

jerqi commented May 29, 2023

@smallzhongfeng Can you assign this issue to me? Thank you very much!

We usually use rest api to control admin service. If we need add api, we would better add rest api. Could we keep consistent with other operation. You can refer to #684

@slfan1989
Copy link
Collaborator

@jerqi Thank you very much for your suggestion, I will finish this pr as soon as possible. Sorry for the late reply.

slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Jun 24, 2023
[apache#837] [Subtask] Display information of all application through…
0f7a1a7 
… Cli.
@slfan1989 slfan1989 mentioned this issue Jun 24, 2023
Merged
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Jun 25, 2023
[apache#837] [Subtask] Display information of all application through…
35b2ef9 
… Cli.
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Jun 25, 2023
[apache#837] [Subtask] Display information of all application through…
5a73aa4 
… Cli.
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Jun 25, 2023
[apache#837] [Subtask] Display information of all application through…
60129a1 
… Cli.
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Jun 25, 2023
[apache#837] [Subtask] Display information of all application through…
5a0967a 
… Cli.
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Jul 12, 2023
[apache#837] Fix CheckStyle.
87e5a32
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Jul 18, 2023
[apache#837] Fix CheckStyle.
3927a65
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Jul 19, 2023
[apache#837] Fix CheckStyle.
ec0a385
slfan1989 pushed a commit to slfan1989/incubator-uniffle that referenced this issue Jul 19, 2023
[apache#837] feat: Display information of all application through Cli.
379c5ac
advancedxy pushed a commit that referenced this issue Aug 11, 2023
@slfan1989
[#837] feat: Display information of all application through Cli. (#964)
1406e1f 
### What changes were proposed in this pull request?

> uniffle client-cli -host localhost -port 9526 --applications --app-list application_1,application_2 --appId-regex application_1 -o JSON

```
sh-3.2# ./uniffle client-cli -host localhost -port 9526 --applications --app-list application_1,application_2 --appId-regex application_1 -o JSON

2023-08-08 18:10:29,130 INFO uniffle.AbstractCustomCommandLine: connected to coordinator: http://localhost:9526.
2023-08-08 18:10:29,517 INFO cli.UniffleCLI: uniffle-client-cli : get applications
application: [{"applicationId":"application_1","user":"test","lastHeartBeatTime":"2023-08-08 18:10:23"}]
```

> uniffle client-cli -host localhost -port 9526 --applications -o JSON

```
sh-3.2# ./uniffle client-cli -host localhost -port 9526 --applications -o JSON
2023-08-08 18:15:06,737 INFO uniffle.AbstractCustomCommandLine: connected to coordinator: http://localhost:9526.
2023-08-08 18:15:07,149 INFO cli.UniffleCLI: uniffle-client-cli : get applications
application: [{"applicationId":"application_0","user":"test","lastHeartBeatTime":"2023-08-08 18:14:51"},{"applicationId":"application_1","user":"test","lastHeartBeatTime":"2023-08-08 18:14:51"},{"applicationId":"application_10","user":"test","lastHeartBeatTime":"2023-08-08 18:14:51"},{"applicationId":"application_100","user":"test","lastHeartBeatTime":"2023-08-08 18:14:51"},{"applicationId":"application_1000","user":"test","lastHeartBeatTime":"2023-08-08 18:14:51"},{"applicationId":"application_1001","user":"test","lastHeartBeatTime":"2023-08-08 18:14:51"},{"applicationId":"application_1002","user":"test","lastHeartBeatTime":"2023-08-08 18:14:51"},{"applicationId":"application_1003","user":"test","lastHeartBeatTime":"2023-08-08 18:14:51"},{"applicationId":"application_1004","user":"test","lastHeartBeatTime":"2023-08-08 18:14:51"},{"applicationId":"application_1005","user":"test","lastHeartBeatTime":"2023-08-08 18:14:51"}]
```

> sh-3.2# ./uniffle client-cli -host localhost -port 9526 --applications
```
sh-3.2# ./uniffle client-cli -host localhost -port 9526 --applications
2023-08-08 18:16:32,561 INFO uniffle.AbstractCustomCommandLine: connected to coordinator: http://localhost:9526.
2023-08-08 18:16:33,066 INFO cli.UniffleCLI: uniffle-client-cli : get applications
+-------------------------------------------------------------------+
|                       Uniffle Applications                        |
+------------------+------+---------------------+-------------------+
|  ApplicationId   | User | Last HeartBeatTime  | RemoteStoragePath |
+------------------+------+---------------------+-------------------+
|  application_0   | test | 2023-08-08 18:16:30 |       null        |
|  application_1   | test | 2023-08-08 18:16:30 |       null        |
|  application_10  | test | 2023-08-08 18:16:30 |       null        |
| application_100  | test | 2023-08-08 18:16:30 |       null        |
| application_1000 | test | 2023-08-08 18:16:30 |       null        |
| application_1001 | test | 2023-08-08 18:16:30 |       null        |
| application_1002 | test | 2023-08-08 18:16:30 |       null        |
| application_1003 | test | 2023-08-08 18:16:30 |       null        |
| application_1004 | test | 2023-08-08 18:16:30 |       null        |
| application_1005 | test | 2023-08-08 18:16:30 |       null        |
+------------------+------+---------------------+-------------------+
```

### Why are the changes needed?
fixes #837 [Subtask] Display information of all application through Cli.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Add Junit Test & Test environment verification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slfan1989 slfan1989

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#837] feat: Display information of all application through Cli. slfan1989/incubator-uniffle
3 participants
@jerqi @slfan1989 @smallzhongfeng