Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#889] improvement: Modify default value of single buffer flush. #1039

Merged
merged 4 commits into from
Jul 26, 2023

Conversation

leixm
Copy link
Contributor

@leixm leixm commented Jul 26, 2023

What changes were proposed in this pull request?

Modify default value of single buffer flush.

Why are the changes needed?

For release 0.8.0.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

exiting UTs.

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Merging #1039 (3910376) into master (96eab1c) will increase coverage by 1.44%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1039      +/-   ##
============================================
+ Coverage     54.32%   55.76%   +1.44%     
+ Complexity     2550     2413     -137     
============================================
  Files           382      349      -33     
  Lines         21737    18003    -3734     
  Branches       1803     1684     -119     
============================================
- Hits          11808    10039    -1769     
+ Misses         9228     7365    -1863     
+ Partials        701      599     -102     
Files Changed Coverage Δ
...a/org/apache/uniffle/server/ShuffleServerConf.java 99.43% <100.00%> (ø)
...he/uniffle/server/buffer/ShuffleBufferManager.java 84.27% <100.00%> (+0.09%) ⬆️

... and 36 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@zuston zuston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zuston zuston merged commit 73c1ba2 into apache:master Jul 26, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants