Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Test compile in Java 11 and Java 17 #105

Merged
merged 6 commits into from Jul 30, 2022
Merged

Conversation

kaijchen
Copy link
Contributor

@kaijchen kaijchen commented Jul 29, 2022

What changes were proposed in this pull request?

  1. Add dependency javax.annotation-api.
  2. Add Java 11 and Java 17 build in CI, mvn package -DskipTests only.
  3. Rename jobs and workflows in CI.
  4. Only check main profiles in sequential workflow, just enough to cover all modules.

Why are the changes needed?

Support build in Java 11 and Java 17.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

https://github.com/kaijchen/incubator-uniffle/actions/runs/2760618905

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2022

Codecov Report

Merging #105 (7ef2679) into master (5f21d2a) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #105      +/-   ##
============================================
- Coverage     56.56%   56.52%   -0.04%     
+ Complexity     1184     1183       -1     
============================================
  Files           149      149              
  Lines          8019     8019              
  Branches        767      767              
============================================
- Hits           4536     4533       -3     
- Misses         3240     3242       +2     
- Partials        243      244       +1     
Impacted Files Coverage Δ
...org/apache/uniffle/server/ShuffleFlushManager.java 76.70% <0.00%> (-1.71%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@kaijchen kaijchen changed the title [CI] Check build in Java 11 and Java 17 [CI] Test compile in Java 11 and Java 17 Jul 30, 2022
Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @kaijchen thanks for your contribution.

@jerqi jerqi merged commit deb7fe4 into apache:master Jul 30, 2022
@jerqi
Copy link
Contributor

jerqi commented Jul 30, 2022

Congrats! 200th commit!

@kaijchen kaijchen deleted the java-17 branch January 18, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants