-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#477] feat(spark): Fix rss.resubmit.stage
does not support dynamic client conf.
#1050
Conversation
…ynamic client conf.
cc @advancedxy PTAL. |
Codecov Report
@@ Coverage Diff @@
## master #1050 +/- ##
============================================
+ Coverage 54.27% 55.40% +1.12%
Complexity 2550 2550
============================================
Files 386 366 -20
Lines 21828 19501 -2327
Branches 1807 1813 +6
============================================
- Hits 11848 10804 -1044
+ Misses 9278 8068 -1210
+ Partials 702 629 -73
... and 24 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
client-spark/spark3/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please check the UT failure of tez module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks all. Merged to master.
What changes were proposed in this pull request?
Fix
rss.resubmit.stage
does not support dynamic client conf.Why are the changes needed?
For #477.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT.