[MINOR] doc: Add JDK benchmark tests #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1059 +/- ##
============================================
+ Coverage 54.27% 55.39% +1.11%
+ Complexity 2550 2549 -1
============================================
Files 386 366 -20
Lines 21828 19501 -2327
Branches 1807 1813 +6
============================================
- Hits 11848 10803 -1045
+ Misses 9278 8068 -1210
+ Partials 702 630 -72 see 26 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Overall LGTM. Left minor comments |
zuston
reviewed
Aug 1, 2023
| @@ -177,7 +177,18 @@ rss-xxx.tgz will be generated for deployment | |||
| ``` | |||
|
|
|||
| ### Deploy Shuffle Server | |||
|
|
|||
| We recommend to use JDK 11+ if we want to have better performance when we deploy the shuffle server. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add JDK benchmark tests
Why are the changes needed?
We should let more users know to use JDK 11+ to deploy shuffle server.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Just doc.