[#1074] feat: Introduce the metric of local_storage_uniffle_used_space
#1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerqi
reviewed
Aug 3, 2023
server/src/main/java/org/apache/uniffle/server/LocalStorageChecker.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1075 +/- ##
============================================
+ Coverage 54.20% 55.29% +1.09%
+ Complexity 2550 2547 -3
============================================
Files 386 366 -20
Lines 21861 19541 -2320
Branches 1813 1815 +2
============================================
- Hits 11850 10806 -1044
+ Misses 9311 8107 -1204
+ Partials 700 628 -72
... and 38 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks for your review @jerqi Merged/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, the local_storage_used_space will show the disks used total size.
But if it is in the colocation with Yarn Nodemanager, this is not enough.
So this issue is to introduce the metric of local_storage_uniffle_used_space to
show the uniffle used space.
Why are the changes needed?
Fix: #1074
Does this PR introduce any user-facing change?
No.
How was this patch tested?