Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] fix(tez): Add output mapOutputRecordCounter metrics #1093

Merged
merged 1 commit into from
Aug 7, 2023
Merged

[MINOR] fix(tez): Add output mapOutputRecordCounter metrics #1093

merged 1 commit into from
Aug 7, 2023

Conversation

bin41215
Copy link
Contributor

@bin41215 bin41215 commented Aug 5, 2023

What changes were proposed in this pull request?

Add output mapOutputRecordCounter metrics

Why are the changes needed?

Add this metrics to fix reducing the number of tasks

Fix: #972

Does this PR introduce any user-facing change?

No.

How was this patch tested?

ut

@jerqi jerqi changed the title [MINOR]Fix(tez) add output mapOutputRecordCounter metrics [MINOR] fix(tez) Add output mapOutputRecordCounter metrics Aug 5, 2023
@jerqi jerqi requested a review from zhengchenyu August 5, 2023 05:08
@jerqi
Copy link
Contributor

jerqi commented Aug 5, 2023

@zhengchenyu Could you help me review this pr?

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2023

Codecov Report

Merging #1093 (4495f81) into master (1411376) will increase coverage by 1.16%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1093      +/-   ##
============================================
+ Coverage     54.07%   55.23%   +1.16%     
+ Complexity     2542     2539       -3     
============================================
  Files           386      366      -20     
  Lines         21879    19521    -2358     
  Branches       1812     1812              
============================================
- Hits          11830    10782    -1048     
+ Misses         9353     8110    -1243     
+ Partials        696      629      -67     
Files Changed Coverage Δ
...ez/runtime/library/common/sort/impl/RssSorter.java 61.62% <ø> (ø)
.../runtime/library/common/sort/impl/RssUnSorter.java 61.62% <ø> (ø)
...library/common/sort/buffer/WriteBufferManager.java 88.99% <100.00%> (-0.37%) ⬇️

... and 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jerqi jerqi changed the title [MINOR] fix(tez) Add output mapOutputRecordCounter metrics [MINOR] fix(tez): Add output mapOutputRecordCounter metrics Aug 5, 2023
@jerqi jerqi merged commit 8cc00d5 into apache:master Aug 7, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] Tez client add missed metric
4 participants