Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize apache-rat excluded files #11

Merged
merged 5 commits into from Jul 4, 2022
Merged

Conversation

kaijchen
Copy link
Contributor

@kaijchen kaijchen commented Jul 4, 2022

What changes were proposed in this pull request?

Add license header to files so we can minimize files to exclude in apache-rat check.

Why are the changes needed?

Asf podding issues

Does this PR introduce any user-facing change?

License header is visible in docs, just like spark, for example:
https://github.com/kaijchen/incubator-uniffle/blob/rat-exclude/docs/index.md

How was this patch tested?

CI: https://github.com/kaijchen/incubator-uniffle/runs/7176341386?check_suite_focus=true

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I use the command git apply spark-3.1.2_dynamic_allocation_support.patch, it's ok. LGTM, thanks for your contribution.

@jerqi jerqi merged commit e53b1cf into apache:master Jul 4, 2022
@kaijchen
Copy link
Contributor Author

kaijchen commented Jul 4, 2022

Thanks @jerqi for the review.

@kaijchen kaijchen deleted the rat-exclude branch July 4, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants