[#1100] improvement(mr): Fail fast in SortWriteBufferManager when failed to send shuffle data to shuffle server. #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to shuffle server.
jerqi
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1103 +/- ##
============================================
+ Coverage 54.22% 55.33% +1.11%
+ Complexity 2553 2542 -11
============================================
Files 386 366 -20
Lines 21871 19522 -2349
Branches 1812 1811 -1
============================================
- Hits 11860 10803 -1057
+ Misses 9312 8091 -1221
+ Partials 699 628 -71
... and 33 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jerqi
approved these changes
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, it only checks for blocks that failed to send after all buffer data has been sent. This check also needs to be moved forward into the addRecord method, allowing it to fail fast.
Why are the changes needed?
Fix: #1100
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Add more test cases.