Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleep less time but try more times when stopping #112

Merged
merged 1 commit into from Jul 30, 2022

Conversation

xianjingfeng
Copy link
Member

What changes were proposed in this pull request?

Sleep less time but try more times when stopping

Why are the changes needed?

Waiting time for executing stop script is too long even if the JVM exits early.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Have already verify in our production enviroment.

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2022

Codecov Report

Merging #112 (6b920d0) into master (deb7fe4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #112   +/-   ##
=========================================
  Coverage     56.52%   56.52%           
  Complexity     1183     1183           
=========================================
  Files           149      149           
  Lines          8019     8019           
  Branches        767      767           
=========================================
  Hits           4533     4533           
  Misses         3242     3242           
  Partials        244      244           

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks @xianjingfeng LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants