Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1132] improvement(spark): Unregister shuffle explicitly when Spark application is stopped. #1139

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

zhuyaogai
Copy link
Contributor

What changes were proposed in this pull request?

Unregister shuffle explicitly when Spark application is stopped.

Why are the changes needed?

Fix: #1132

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Add more test cases.

@jerqi jerqi changed the title [#1132][Improvement] (spark): Unregister shuffle explicitly when Spark application is stopped. [#1132] improvement(spark): Unregister shuffle explicitly when Spark application is stopped. Aug 13, 2023
@jerqi jerqi requested a review from zuston August 13, 2023 03:09
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2023

Codecov Report

Merging #1139 (05f6259) into master (1406e1f) will increase coverage by 1.10%.
The diff coverage is 60.00%.

@@             Coverage Diff              @@
##             master    #1139      +/-   ##
============================================
+ Coverage     53.70%   54.81%   +1.10%     
- Complexity     2573     2574       +1     
============================================
  Files           391      371      -20     
  Lines         22314    19959    -2355     
  Branches       1867     1868       +1     
============================================
- Hits          11984    10940    -1044     
+ Misses         9622     8382    -1240     
+ Partials        708      637      -71     
Files Changed Coverage Δ
...he/uniffle/client/impl/ShuffleWriteClientImpl.java 36.24% <60.00%> (+0.26%) ⬆️

... and 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@zuston zuston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your effort @zhuyaogai

@zuston zuston merged commit 9723e9d into apache:master Aug 15, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Unregister shuffle explicitly when Spark application is stopped
3 participants