Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Followup] Migrate to Junit5 #14

Merged
merged 1 commit into from Jul 4, 2022
Merged

[Followup] Migrate to Junit5 #14

merged 1 commit into from Jul 4, 2022

Conversation

zuston
Copy link
Member

@zuston zuston commented Jul 4, 2022

What changes were proposed in this pull request?

Migrate to Junit5 in module of server.

Why are the changes needed?

Now, the module of server test cases are invalid.

Does this PR introduce any user-facing change?

No

How was this patch tested?

No need.

Copy link
Contributor

@kaijchen kaijchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zuston for the improvement, LGTM.

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@jerqi jerqi merged commit d8fd9b1 into apache:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants