Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#134][FOLLOWUP] improvement(spark2): Use taskId and attemptNo as taskAttemptId #1544

Merged

Conversation

EnricoMi
Copy link
Contributor

What changes were proposed in this pull request?

Use map index and task attempt number as the task attempt id in Spark2.

Why are the changes needed?

This aligns Spark2 taskAttemptId of the blockId with Spark3.

See #1529

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing integration tests.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.56%. Comparing base (ff555c5) to head (e41146c).
Report is 8 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1544      +/-   ##
============================================
+ Coverage     54.15%   54.56%   +0.40%     
- Complexity     2805     2822      +17     
============================================
  Files           431      416      -15     
  Lines         24421    22185    -2236     
  Branches       2081     2080       -1     
============================================
- Hits          13226    12105    -1121     
+ Misses        10363     9331    -1032     
+ Partials        832      749      -83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 27, 2024

Test Results

2 312 files  ±0  2 312 suites  ±0   4h 38m 15s ⏱️ + 1m 54s
  822 tests ±0    821 ✅ ±0   1 💤 ±0  0 ❌ ±0 
9 683 runs  +4  9 669 ✅ +4  14 💤 ±0  0 ❌ ±0 

Results for commit 0762498. ± Comparison against base commit a73dcb9.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
org.apache.spark.shuffle.RssShuffleManagerTest ‑ testGetTaskAttemptIdWithSpeculation
org.apache.spark.shuffle.RssShuffleManagerTest ‑ testGetTaskAttemptIdWithoutSpeculation
org.apache.uniffle.shuffle.manager.RssShuffleManagerBaseTest ‑ testGetTaskAttemptIdWithSpeculation
org.apache.uniffle.shuffle.manager.RssShuffleManagerBaseTest ‑ testGetTaskAttemptIdWithoutSpeculation

♻️ This comment has been updated with latest results.

@EnricoMi EnricoMi force-pushed the blockid-with-mapindex-attemptno-spark2 branch from e41146c to 0762498 Compare February 27, 2024 08:06
Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks @EnricoMi

@jerqi jerqi merged commit 37ec78b into apache:master Feb 29, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants