Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR][DOC] Remove spaces when reading file of excluded nodes #155

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

smallzhongfeng
Copy link
Contributor

@smallzhongfeng smallzhongfeng commented Aug 11, 2022

What changes were proposed in this pull request?

Remove spaces when reading file of excluded nodes and the use of the excluded node file was added to the coordinator's introduction document.

Why are the changes needed?

More user-friendly.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

No need.

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2022

Codecov Report

Merging #155 (5dfd7d5) into master (9f86054) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #155      +/-   ##
============================================
+ Coverage     57.35%   57.38%   +0.03%     
- Complexity     1207     1208       +1     
============================================
  Files           150      150              
  Lines          8209     8209              
  Branches        775      775              
============================================
+ Hits           4708     4711       +3     
+ Misses         3257     3255       -2     
+ Partials        244      243       -1     
Impacted Files Coverage Δ
...ache/uniffle/coordinator/SimpleClusterManager.java 91.07% <100.00%> (ø)
...org/apache/uniffle/server/ShuffleFlushManager.java 78.53% <0.00%> (+1.69%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @smallzhongfeng

@jerqi jerqi merged commit f49b566 into apache:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants