-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(spark): add all faulty servers into blacklist while writing for stage recomputing #1578
base: master
Are you sure you want to change the base?
Conversation
Could you help review this? @yl09099 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1578 +/- ##
============================================
+ Coverage 53.99% 54.95% +0.96%
Complexity 2862 2862
============================================
Files 438 418 -20
Lines 24819 22480 -2339
Branches 2111 2113 +2
============================================
- Hits 13402 12355 -1047
+ Misses 10578 9355 -1223
+ Partials 839 770 -69 ☔ View full report in Codecov by Sentry. |
Test Results 2 315 files - 25 2 315 suites - 25 3h 57m 13s ⏱️ - 34m 43s Results for commit 1f1d00c. ± Comparison against base commit f6569b0. This pull request removes 16 tests.
♻️ This comment has been updated with latest results. |
LGTM~ |
Do you add a new ut for this case? |
I'm still reviewing this part. |
What changes were proposed in this pull request?
add all faulty servers into blacklist while writing for stage recomputing
Why are the changes needed?
It will fail on retry when only one server is added into blacklist.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.