[#1634] fix(server): remove app folder if app is expired #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you help review this? @rickyma |
Test Results 2 363 files ±0 2 363 suites ±0 4h 30m 38s ⏱️ +47s For more details on these failures, see this check. Results for commit 42766c8. ± Comparison against base commit a7a0b4c. ♻️ This comment has been updated with latest results. |
rickyma
reviewed
Apr 10, 2024
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/apache/uniffle/server/ShuffleTaskManagerTest.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/apache/uniffle/server/ShuffleTaskManagerTest.java
Outdated
Show resolved
Hide resolved
jerqi
approved these changes
Apr 12, 2024
jerqi
pushed a commit
that referenced
this pull request
Apr 30, 2024
### What changes were proposed in this pull request? Always executing the removeResources no matter whether blockIds remain. ### Why are the changes needed? Fix: #1634 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Using existing unit tests, but additionally checking the app folder after app is expired.
zuston
added a commit
to zuston/incubator-uniffle
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Always executing the removeResources no matter whether blockIds remain.
Why are the changes needed?
Fix: #1634
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Using existing unit tests, but additionally checking the app folder after app is expired.