Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FOLLOWUP] Delete hdfs shuffle data files using proxy user #170

Merged
merged 3 commits into from Aug 22, 2022

Conversation

zuston
Copy link
Member

@zuston zuston commented Aug 20, 2022

What changes were proposed in this pull request?

Delete shuffle data files stored on secured hdfs using proxy user

Why are the changes needed?

In previous PR #53, we introduce the proxy user for shuffle server to write shuffle data to HDFS.
But I ignored that the shuffle server should also delete these files by the way of proxy user.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Manual tests on kerberos HDFS cluster, and unit tests.

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2022

Codecov Report

Merging #170 (4584f67) into master (abb9215) will increase coverage by 0.03%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master     #170      +/-   ##
============================================
+ Coverage     58.25%   58.29%   +0.03%     
- Complexity     1261     1262       +1     
============================================
  Files           158      158              
  Lines          8397     8397              
  Branches        779      779              
============================================
+ Hits           4892     4895       +3     
+ Misses         3253     3251       -2     
+ Partials        252      251       -1     
Impacted Files Coverage Δ
...he/uniffle/server/storage/MultiStorageManager.java 37.50% <0.00%> (ø)
...storage/handler/impl/HdfsShuffleDeleteHandler.java 0.00% <0.00%> (ø)
...e/storage/handler/impl/LocalFileDeleteHandler.java 0.00% <ø> (ø)
.../org/apache/uniffle/server/ShuffleTaskManager.java 64.60% <100.00%> (ø)
...che/uniffle/server/storage/HdfsStorageManager.java 92.68% <100.00%> (ø)
...he/uniffle/server/storage/LocalStorageManager.java 61.53% <100.00%> (ø)
...org/apache/uniffle/server/ShuffleFlushManager.java 79.32% <0.00%> (+1.67%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zuston
Copy link
Member Author

zuston commented Aug 21, 2022

PTAL @jerqi @colinmjj

@jerqi jerqi changed the title [follow-up] Delete hdfs shuffle data files using proxy user [FOLLOWUP] Delete hdfs shuffle data files using proxy user Aug 22, 2022
Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merged. Thanks @zuston

@jerqi jerqi merged commit 270e2ad into apache:master Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants