New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-48][FEATURE][FOLLOW UP] Add RemoteShuffleService CRD #175
Conversation
@zuston @thousandhu @czy006 Could you help me review this patch? |
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
============================================
+ Coverage 58.29% 58.41% +0.11%
- Complexity 1262 1271 +9
============================================
Files 158 158
Lines 8397 8428 +31
Branches 779 782 +3
============================================
+ Hits 4895 4923 +28
- Misses 3251 3253 +2
- Partials 251 252 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
68087c8
to
d7ee6cc
Compare
deploy/kubernetes/operator/api/uniffle/v1alpha1/remoteshuffleservice_types.go
Outdated
Show resolved
Hide resolved
d7ee6cc
to
99e7e29
Compare
LGTM , thanks @wangao1236 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @wangao1236 @thousandhu , @zuston @czy006 if you have another suggestion, you can raise a new pr.
What changes were proposed in this pull request?
for issue #48
I add a crd object called RemoteShuffleService this time, and I will submit the controller of the crd in next pr.
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?