Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-48][FEATURE][FOLLOW UP] Add RemoteShuffleService CRD #175

Merged
merged 1 commit into from Aug 25, 2022

Conversation

wangao1236
Copy link
Collaborator

What changes were proposed in this pull request?

for issue #48
I add a crd object called RemoteShuffleService this time, and I will submit the controller of the crd in next pr.

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

@jerqi
Copy link
Contributor

jerqi commented Aug 22, 2022

@zuston @thousandhu @czy006 Could you help me review this patch?

@jerqi jerqi linked an issue Aug 22, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2022

Codecov Report

Merging #175 (99e7e29) into master (74cd40b) will increase coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #175      +/-   ##
============================================
+ Coverage     58.29%   58.41%   +0.11%     
- Complexity     1262     1271       +9     
============================================
  Files           158      158              
  Lines          8397     8428      +31     
  Branches        779      782       +3     
============================================
+ Hits           4895     4923      +28     
- Misses         3251     3253       +2     
- Partials        251      252       +1     
Impacted Files Coverage Δ
...che/uniffle/server/storage/HdfsStorageManager.java 90.00% <0.00%> (-2.69%) ⬇️
...e/spark/shuffle/reader/RssShuffleDataIterator.java 88.73% <0.00%> (-0.98%) ⬇️
.../org/apache/uniffle/server/ShuffleTaskManager.java 64.28% <0.00%> (-0.32%) ⬇️
...a/org/apache/uniffle/server/ShuffleServerConf.java 99.18% <0.00%> (+0.03%) ⬆️
...he/uniffle/server/buffer/ShuffleBufferManager.java 82.77% <0.00%> (+0.52%) ⬆️
...ava/org/apache/uniffle/server/ShuffleTaskInfo.java 93.75% <0.00%> (+2.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wangao1236 wangao1236 force-pushed the feat-open-source branch 2 times, most recently from 68087c8 to d7ee6cc Compare August 23, 2022 07:05
@wangao1236 wangao1236 requested a review from jerqi August 23, 2022 08:20
@thousandhu
Copy link

LGTM , thanks @wangao1236

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @wangao1236 @thousandhu , @zuston @czy006 if you have another suggestion, you can raise a new pr.

@jerqi jerqi merged commit c25e5a1 into apache:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants