Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1608] improvement(spark3): Output more task level infos in driver side when reassigning on block sent failure #1771

Merged
merged 1 commit into from
Jun 11, 2024
Merged

[#1608] improvement(spark3): Output more task level infos in driver side when reassigning on block sent failure #1771

merged 1 commit into from
Jun 11, 2024

Conversation

zuston
Copy link
Member

@zuston zuston commented Jun 11, 2024

What changes were proposed in this pull request?

  1. Output more task level logs (like taskId, executorId and so on) in driver side
  2. Fix typo of ReassignServersResponse

Why are the changes needed?

For better seeing the more contexts when reassign happens

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Needn't

@zuston
[apache#1608] improvement(spark3): Output more task level infos in dr…
be0dda7 
…iver side when reassigning on block sent failure
@zuston zuston requested a review from jerqi June 11, 2024 03:47
@github-actions GitHub Actions
Copy link

Test Results

 2 433 files  ±0   2 433 suites  ±0   5h 0m 18s ⏱️ +23s
   934 tests ±0     933 ✅ ±0   1 💤 ±0  0 ❌ ±0 
10 828 runs  ±0  10 814 ✅ ±0  14 💤 ±0  0 ❌ ±0 

Results for commit be0dda7. ± Comparison against base commit 648931c.

jerqi
jerqi approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zuston zuston merged commit 1c72cb7 into apache:master Jun 11, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerqi jerqi jerqi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zuston @jerqi