[#1608] feat(spark3): Ensure the compatiblity of reassign and stageRetry #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuston
commented
Jun 13, 2024
| @@ -638,7 +638,7 @@ public ShuffleHandleInfo getShuffleHandleInfoByShuffleId(int shuffleId) { | |||
| @Override | |||
| public int getMaxFetchFailures() { | |||
| final String TASK_MAX_FAILURE = "spark.task.maxFailures"; | |||
| return Math.max(1, sparkConf.getInt(TASK_MAX_FAILURE, 4) - 1); | |||
| return Math.max(0, sparkConf.getInt(TASK_MAX_FAILURE, 4) - 1); | |||
There was a problem hiding this comment.
I think the original 1 is wrong if the spark.task.max.failure=1 that won't trigger the stage retry
There was a problem hiding this comment.
Could you add this into the comment?
rickyma
reviewed
Jun 13, 2024
client-spark/common/src/main/java/org/apache/uniffle/shuffle/manager/RssShuffleManagerBase.java
Outdated
Show resolved
Hide resolved
rickyma
reviewed
Jun 13, 2024
client-spark/common/src/main/java/org/apache/uniffle/shuffle/manager/RssShuffleManagerBase.java
Outdated
Show resolved
Hide resolved
|
ping @jerqi |
|
cc @rickyma |
rickyma
reviewed
Jun 19, 2024
| @@ -638,7 +638,7 @@ public ShuffleHandleInfo getShuffleHandleInfoByShuffleId(int shuffleId) { | |||
| @Override | |||
| public int getMaxFetchFailures() { | |||
| final String TASK_MAX_FAILURE = "spark.task.maxFailures"; | |||
| return Math.max(1, sparkConf.getInt(TASK_MAX_FAILURE, 4) - 1); | |||
| return Math.max(0, sparkConf.getInt(TASK_MAX_FAILURE, 4) - 1); | |||
There was a problem hiding this comment.
Could you add this into the comment?
rickyma
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Ensure the compatiblity of reassign and stageRetry.
Why are the changes needed?
To improve the job stability if having reassign and stage retry.
For #1608
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit tests