Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-173][FOLLOWUP] The size of single buffer flush should reach rss.server.flush.cold.storage.threshold.size #180

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

leixm
Copy link
Contributor

@leixm leixm commented Aug 23, 2022

What changes were proposed in this pull request?

follow #173, when single buffer flush is triggered, the buffer size should reach rss.server.flush.cold.storage.threshold.size, we keep the same logic as MultiStorageManager#selectStorageManager

Why are the changes needed?

Make sure cold storage is valid

Does this PR introduce any user-facing change?

No

How was this patch tested?

Already added

…s.server.flush.cold.storage.threshold.size
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2022

Codecov Report

Merging #180 (aec72e1) into master (6cbd9b7) will increase coverage by 0.02%.
The diff coverage is 84.61%.

@@             Coverage Diff              @@
##             master     #180      +/-   ##
============================================
+ Coverage     58.38%   58.40%   +0.02%     
- Complexity     1266     1269       +3     
============================================
  Files           158      158              
  Lines          8417     8426       +9     
  Branches        780      782       +2     
============================================
+ Hits           4914     4921       +7     
- Misses         3251     3253       +2     
  Partials        252      252              
Impacted Files Coverage Δ
...che/uniffle/server/storage/HdfsStorageManager.java 90.00% <83.33%> (-2.69%) ⬇️
...he/uniffle/server/buffer/ShuffleBufferManager.java 82.77% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leixm ,Merged.

@jerqi jerqi merged commit e968c00 into apache:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants