Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FOLLOWUP] Store app user in ShuffleTaskInfo #181

Merged
merged 1 commit into from Aug 23, 2022

Conversation

smallzhongfeng
Copy link
Contributor

What changes were proposed in this pull request?

Store app user information in shuffleTaskInfo.

Why are the changes needed?

Reduce cache.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Passed the ut.

@smallzhongfeng smallzhongfeng changed the title [FOLLOWUP] Store app user in shuffleTaskInfo [FOLLOWUP] Store app user in ShuffleTaskInfo Aug 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2022

Codecov Report

Merging #181 (2e3a7aa) into master (e968c00) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #181      +/-   ##
============================================
+ Coverage     58.39%   58.41%   +0.02%     
- Complexity     1268     1271       +3     
============================================
  Files           158      158              
  Lines          8426     8428       +2     
  Branches        782      782              
============================================
+ Hits           4920     4923       +3     
+ Misses         3254     3253       -1     
  Partials        252      252              
Impacted Files Coverage Δ
...ava/org/apache/uniffle/server/ShuffleTaskInfo.java 93.75% <100.00%> (+2.08%) ⬆️
.../org/apache/uniffle/server/ShuffleTaskManager.java 64.28% <100.00%> (-0.32%) ⬇️
...storage/handler/impl/DataSkippableReadHandler.java 84.37% <0.00%> (+3.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @smallzhongfeng

@jerqi jerqi merged commit 5864420 into apache:master Aug 23, 2022
@smallzhongfeng
Copy link
Contributor Author

Thanks for your review. @jerqi Just minor changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants