[FOLLOWUP] Add the conf of rss.security.hadoop.krb5-conf.file #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why isn't the test necessary? Should we add some documents? |
|
Yes. Security section doc is added. Test cases may be added tomorrow. |
|
There is a flaky test about Kerboros, if you have time, could you fix it? |
jerqi
reviewed
Aug 26, 2022
common/src/test/java/org/apache/uniffle/common/security/HadoopSecurityContextTest.java
Show resolved
Hide resolved
|
There is a another flaky test about kerberos. |
|
This failure looks the problem of DNS. I'm trying fix |
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
============================================
+ Coverage 58.37% 58.45% +0.07%
- Complexity 1270 1272 +2
============================================
Files 158 158
Lines 8428 8437 +9
Branches 782 782
============================================
+ Hits 4920 4932 +12
+ Misses 3255 3254 -1
+ Partials 253 251 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jerqi
approved these changes
Aug 26, 2022
|
Thanks @jerqi Oh, the description should be changed to match more things involved in this PR. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add the conf of
rss.security.hadoop.krb5-conf.fileWhy are the changes needed?
Follow up #53 , the krb5 conf file can be configured in
SecurityConfig, and also should be configured in shuffle-server/coordinator conf for users.Does this PR introduce any user-facing change?
Yes
How was this patch tested?
Not necessary.