[ISSUE-123] Fix all test code style #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To solve all module test code style in pr Tencent/Firestorm#155 Why are the changes needed? Improve test code style Does this PR introduce any user-facing change? No How was this patch tested? All test and check-style passed on my local machine
kaijchen
approved these changes
Aug 24, 2022
jerqi
approved these changes
Aug 24, 2022
There was a problem hiding this comment.
LGTM, great work! Thanks for your contribution @macroguo-ghy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve all module test code style in pr Tencent/Firestorm#155
Why are the changes needed?
Improve test code style
Does this PR introduce any user-facing change?
No
How was this patch tested?
All test and check-style passed
https://github.com/macroguo-ghy/incubator-uniffle/runs/7974486008?check_suite_focus=true
but im not sure if commits by other contributor violate the checkstyle...